Messages in this thread Patch in this message | | | From | Julia Lawall <> | Subject | [PATCH 4/5] drivers/parport/parport_gsc.c: add missing kfree | Date | Mon, 4 Jul 2011 16:11:44 +0200 |
| |
From: Julia Lawall <julia@diku.dk>
ops was allocated previously in this function, so it should be freed before leaving the function, as done in other nearby error-handling code.
The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/)
// <smpl> @r@ identifier x; @@
kfree(x)
@@ identifier r.x; expression E1!=0,E2,E3,E4; statement S; @@
( if (<+...x...+>) S | if (...) { ... when != kfree(x) when != if (...) { ... kfree(x); ... } when != x = E3 * return E1; } ... when != x = E2 if (...) { ... when != x = E4 kfree(x); ... return ...; } ) // </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
--- drivers/parport/parport_gsc.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/parport/parport_gsc.c b/drivers/parport/parport_gsc.c index 5d6de38..352f961 100644 --- a/drivers/parport/parport_gsc.c +++ b/drivers/parport/parport_gsc.c @@ -271,6 +271,7 @@ struct parport *__devinit parport_gsc_probe_port (unsigned long base, if (!parport_SPP_supported (p)) { /* No port. */ kfree (priv); + kfree(ops); return NULL; } parport_PS2_supported (p);
| |