Messages in this thread | | | From | Péter Ujfalusi <> | Subject | Re: Re: [PATCH v6 08/18] mfd: twl6040: Add initial support | Date | Mon, 4 Jul 2011 16:09:30 +0300 |
| |
Hi Felipe, Samuel,
On Monday 04 July 2011 14:53:30 Balbi, Felipe wrote: > > + ret = twl6040_request_irq(twl6040, TWL6040_IRQ_READY, > > + twl6040_naudint_handler, 0, > > + "twl6040_irq_ready", twl6040); > > why don't you use the normal request_threaded_irq() ?? This is a bit of > obfuscation IMO.
I have left this 'macro' in since it is also used within the twl6040-vibra, and twl6040 ASoC codec driver to request the irq for them. But if you think it is better to replace the twl6040_request_irq with direct request_threaded_irq in those drivers as well, I'll do that.
-- Péter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |