lkml.org 
[lkml]   [2011]   [Jul]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: Re: [PATCH v6 08/18] mfd: twl6040: Add initial support
Date
Hi Felipe, Samuel,

On Monday 04 July 2011 14:53:30 Balbi, Felipe wrote:
> > + ret = twl6040_request_irq(twl6040, TWL6040_IRQ_READY,
> > + twl6040_naudint_handler, 0,
> > + "twl6040_irq_ready", twl6040);
>
> why don't you use the normal request_threaded_irq() ?? This is a bit of
> obfuscation IMO.

I have left this 'macro' in since it is also used within the twl6040-vibra,
and twl6040 ASoC codec driver to request the irq for them.
But if you think it is better to replace the twl6040_request_irq with direct
request_threaded_irq in those drivers as well, I'll do that.

--
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2011-07-04 15:11    [W:0.098 / U:0.560 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site