Messages in this thread | | | Date | Mon, 4 Jul 2011 21:51:40 +1000 | From | Anton Blanchard <> | Subject | Re: [PATCH] perf report/annotate: Add option to specify a CPU range |
| |
Hi,
Ingo Molnar <mingo@elte.hu> wrote:
> * David Ahern <dsahern@gmail.com> wrote: > > It would be better to make this a function that all 3 commands > > reference -- something like perf_session__cpu_bitmap(session, > > cpu_list, cpu_bitmap) in util/session.c > > Agreed. I can see how it ended up looking like this (fixing only perf > report, then adding it to top, then to script), but at this stage it > really calls for one helper that all three commands can utilize.
Yeah, it was dying to be consolidated. New version on the way.
> Very nice enhancement otherwise - might i suggest a 'perf top' hotkey > as well to limit the output to certain CPUs only? :-)
Good idea :) I'll have a go at it.
Anton
| |