lkml.org 
[lkml]   [2011]   [Jul]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: 2.6.xx: NFS: directory motion/cam2 contains a readdir loop


    On Fri, 29 Jul 2011, Justin Piszcz wrote:

    >
    >
    > On Fri, 29 Jul 2011, Trond Myklebust wrote:
    >
    > > On Fri, 2011-07-29 at 16:59 -0400, Justin Piszcz wrote:
    > >> On Fri, 29 Jul 2011, Bryan Schumaker wrote:
    > >>
    > >>> How does this look for printing out more information when a cookie loop is detected? Is there anything else that should be printed out? My patch applies on top of Trond's from yesterday.
    > >>
    > >>
    > >> Hi,
    > >>
    > >> This fails against 2.6.38:
    > >>
    > >> patching file fs/nfs/dir.c
    > >> Hunk #1 FAILED at 134.
    > >> Hunk #2 FAILED at 173.
    > >> Hunk #3 FAILED at 323.
    > >> Hunk #4 FAILED at 336.
    > >> Hunk #5 FAILED at 349.
    > >> Hunk #6 succeeded at 320 (offset -48 lines).
    > >> Hunk #7 FAILED at 741.
    > >> Hunk #8 succeeded at 716 (offset -59 lines).
    > >> Hunk #9 succeeded at 749 (offset -59 lines).
    > >> Hunk #10 succeeded at 763 (offset -59 lines).
    > >> 6 out of 10 hunks FAILED -- saving rejects to file fs/nfs/dir.c.rej
    > >> patching file include/linux/nfs_fs.h
    > >> Hunk #1 FAILED at 99.
    > >> 1 out of 1 hunk FAILED -- saving rejects to file include/linux/nfs_fs.h.rej
    > >> atom:/usr/src/linux#
    > >>
    > >> And the 3.0 kernel is broken for my wireless adapter:
    > >> http://www.gossamer-threads.com/lists/linux/kernel/1411576
    > >>
    > >> If you can make a combined patch for 2.6.38 I can try it, 2.6.39+ have a
    > >> horrible driver (rt2800usb) and 1 person emailed me as well stating the
    > >> same thing off-list (they stick with the manufacturer's driver or the *sta
    > >> one).
    > >
    > > I don't understand. The readdir loop detection code was first merged
    > > upstream in 2.6.39. 2.6.38 doesn't report any loops...
    >
    > Hi,
    >
    > Sorry--(my error) this is meant for the client, patched & will e-mail when
    > it happens again.
    >
    > # patch -p1 < /home/jpiszcz/patch1
    > patching file fs/nfs/dir.c
    > patching file include/linux/nfs_fs.h
    >
    > # patch -p1 < /home/jpiszcz/patch2
    > patching file fs/nfs/dir.c
    >
    > (recompile->reboot->waiting for next error)
    >
    > Justin.

    So I have been running Linux 2.6.37-(.. 3.0 recently) since Jan of this year on these new hosts and I have never had so much as a kernel OOPS, with these
    patches, there were several kernel lockups/problems but the nfs/loop did
    not show up.

    I've went back to the previous (non-patched) kernel, is there a less invasive
    patch?

    http://home.comcast.net/~jpiszcz/20110730/kernel-error.txt

    Justin.




    \
     
     \ /
      Last update: 2011-07-30 12:01    [W:0.027 / U:31.408 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site