lkml.org 
[lkml]   [2011]   [Jul]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] drivers: char: i8k: Use __packed
    Date
    On Sunday 03 July 2011 03:30:05 Chris Forbes wrote:
    > diff --git a/drivers/char/i8k.c b/drivers/char/i8k.c
    > index 6e40072..d9c93d4 100644
    > --- a/drivers/char/i8k.c
    > +++ b/drivers/char/i8k.c
    > @@ -103,11 +103,11 @@ static const struct file_operations i8k_fops = {
    >
    > struct smm_regs {
    > unsigned int eax;
    > - unsigned int ebx __attribute__ ((packed));
    > - unsigned int ecx __attribute__ ((packed));
    > - unsigned int edx __attribute__ ((packed));
    > - unsigned int esi __attribute__ ((packed));
    > - unsigned int edi __attribute__ ((packed));
    > + unsigned int ebx __packed;
    > + unsigned int ecx __packed;
    > + unsigned int edx __packed;
    > + unsigned int esi __packed;
    > + unsigned int edi __packed;
    > };

    The attribute is not useful at all here, because the structure is guaranteed
    to be packed anyway. Better just remote the attributes without replacement.

    Arnd


    \
     
     \ /
      Last update: 2011-07-03 18:07    [W:0.021 / U:1.552 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site