Messages in this thread | | | From | Linus Torvalds <> | Date | Sun, 3 Jul 2011 14:34:39 -0700 | Subject | Re: [PATCH v2] kernel: escape non-ASCII and control characters in printk() |
| |
On Sun, Jul 3, 2011 at 2:10 PM, Alan Cox <alan@lxorguk.ukuu.org.uk> wrote: > > In which case we can't do it because we need \n in proc content so that's > a complete and utter non starter.
You didn't read the original email I sent, did you?
For people who _want_ the unsafe versions with \n and other control characters, they'd use a "raw string" format. Something like our extended "%p" formats. Maybe '%p[]' - we could allow extensions later that describe which characters to escape inside the brackets (for example, we currently have ad-hoc escaping of things like pathnames: with '/' not being legal in a path component)
The point being that that way it would be (a) safe by default (b) require _thought_ when you actually wanted to print control characters and (c) be easily greppable too.
Linus
| |