lkml.org 
[lkml]   [2011]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 2/7] perf, x86: Implement IBS initialization
    From
    Date
    On Thu, 2011-07-28 at 15:46 +0200, Robert Richter wrote:
    > +static int perf_ibs_add(struct perf_event *event, int flags)
    > +{
    > + pr_info("Adding event %p (config=%016llx) to pmu %s (type=%d) on cpu %d\n",
    > + event, event->attr.config, perf_ibs.name, event->attr.type, event->oncpu);
    > + return 0;
    > +}
    > +
    > +static void perf_ibs_del(struct perf_event *event, int flags)
    > +{
    > + pr_info("Removing event %p (config=%016llx) to pmu %s (type=%d) on cpu %d\n",
    > + event, event->attr.config, perf_ibs.name, event->attr.type, event->oncpu);
    > +}

    While I see you remove them later on, I do find it somewhat strange to
    have them here. This is user triggerable code in the context switch
    path, lots of nasty can come from this.


    \
     
     \ /
      Last update: 2011-07-29 19:01    [W:0.038 / U:31.064 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site