lkml.org 
[lkml]   [2011]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] sunrpc: use better NUMA affinities
    Date


    Sent from my iPhone

    On 29/07/2011, at 20:36, Christoph Hellwig <hch@infradead.org> wrote:

    > On Fri, Jul 29, 2011 at 04:53:21PM +1000, Greg Banks wrote:
    >>> Check commit 94dcf29a11b3d20a (kthread: use kthread_create_on_node
    >>> ()) to
    >>> see how this strategy already was adopted for ksoftirqd, kworker,
    >>> migration, and pktgend kthreads.
    >>
    >> Ah, I see. It's unfortunate that the kthread_create() API ends up
    >> being passed a CPU number but that's only used to format the name
    >> and not for sensible things :(
    >
    > kthread_create doesn't have a cpu argument - it has a printf-like
    > format
    > string.
    >

    Sure, and a whole lot of the callsites are ("..._%d", cpu), hence the
    unfortune :(

    Greg.


    \
     
     \ /
      Last update: 2011-07-29 14:01    [W:0.021 / U:32.888 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site