lkml.org 
[lkml]   [2011]   [Jul]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] Fix a argument WARN bug of scripts/checkpatch.pl
    Sorry the prev patch have the format error.  So I re-send it.

    Get following error with a patch that have min_t error:
    Use of uninitialized value in concatenation (.) or string at
    scripts/checkpatch.pl line 1256.
    WARNING:
    This is because:
    }
    WARN("$call() should probably be ${call}_t($cast, $arg1, $arg2)\n" . $herecurr);
    }
    It lost the first argument.
    So make a patch to fix it.

    Signed-off-by: Hui Zhu <teawater@gmail.com>
    ---
    scripts/checkpatch.pl | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    --- a/scripts/checkpatch.pl
    +++ b/scripts/checkpatch.pl
    @@ -2574,7 +2574,8 @@ sub process {
    } else {
    $cast = $cast2;
    }
    - WARN("$call() should probably be ${call}_t($cast, $arg1, $arg2)\n" . $herecurr);
    + WARN("MINMAX",
    + "$call() should probably be ${call}_t($cast, $arg1, $arg2)\n" . $herecurr);
    }
    }


    \
     
     \ /
      Last update: 2011-07-28 09:25    [W:0.026 / U:30.132 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site