Messages in this thread | | | Subject | Re: [PATCH 1/9] watchdog: WatchDog Timer Driver Core - Add basic framework | From | Joe Perches <> | Date | Thu, 28 Jul 2011 14:29:53 -0700 |
| |
On Wed, 2011-07-27 at 20:16 +0000, Wim Van Sebroeck wrote: > The WatchDog Timer Driver Core is a framework > that contains the common code for all watchdog-driver's. > It also introduces a watchdog device structure and the > operations that go with it. > > This is the introduction of this framework. This part > supports the minimal watchdog userspace API (or with > other words: the functionality to use /dev/watchdog's > open, release and write functionality as defined in > the simplest watchdog API). Extra functionality will > follow in the next set of patches.
Perhaps add some logging helpers to the .h?
#define wdd_emerg(wd, fmt, ...) \ pr_emerg("%s: " fmt, (wd)->info->identity, ##__VA_ARGS__) #define wdd_crit(wd, fmt, ...) \ pr_crit("%s: " fmt, (wd)->info->identity, ##__VA_ARGS__) #define wdd_alert(wd, fmt, ...) \ pr_alert("%s: " fmt, (wd)->info->identity, ##__VA_ARGS__) #define wdd_err(wd, fmt, ...) \ pr_err("%s: " fmt, (wd)->info->identity, ##__VA_ARGS__) #define wdd_notice(wd, fmt, ...) \ pr_notice("%s: " fmt, (wd)->info->identity, ##__VA_ARGS__) #define wdd_warn(wd, fmt, ...) \ pr_warn("%s: " fmt, (wd)->info->identity, ##__VA_ARGS__) #define wdd_info(wd, fmt, ...) \ pr_info("%s: " fmt, (wd)->info->identity, ##__VA_ARGS__) #define wdd_dbg(wd, fmt, ...) \ pr_debug("%s: " fmt, (wd)->info->identity, ##__VA_ARGS__)
> + err = misc_register(&watchdog_miscdev); > + if (err != 0) { > + pr_err("%s: cannot register miscdev on minor=%d (err=%d).\n", > + watchdog->info->identity, WATCHDOG_MINOR, err);
wdd_err(watchdog, "cannot register watchdog on minor %d, err: %d\n", WATCHDOG_MINOR, err);
etc...
| |