lkml.org 
[lkml]   [2011]   [Jul]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 1/2] MMC / TMIO: Fix build issue related to struct scatterlist
    Date
    On Thursday, July 28, 2011, Guennadi Liakhovetski wrote:
    > On Wed, 27 Jul 2011, Rafael J. Wysocki wrote:
    >
    > > On Wednesday, July 27, 2011, Guennadi Liakhovetski wrote:
    > > > (added MMC maintainer to CC:)
    > > >
    > > > On Tue, 26 Jul 2011, Rafael J. Wysocki wrote:
    > > >
    > > > > From: Rafael J. Wysocki <rjw@sisk.pl>
    > > > >
    > > > > Fix build issue caused by undefined struct scatterlist in
    > > > > drivers/mmc/host/tmio_mmc.c.
    > > > >
    > > > > Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
    > > >
    > > > A nitpick, if I may: sCatterlist comes before sPinlock in my versions of
    > > > most popular alphabets;-) Please, fix (or maybe Chris can fix it himself),
    > >
    > > I'm not sure what you mean exactly (perhaps it's too late).
    >
    > I mean, that the headers are atm sorted alphabetically and should remain
    > so, therefore you should add the new header one line higher.

    Ah. Well, as I said the patch had been merged already, so obviously
    Linus didn't care. :-)

    > As for compile failure or not: I haven't seen any compile failures myself, but
    > the patch is academically correct, because structs, declared in tmio_mmc.h
    > embed struct scatterlist, therefore the header has to be included in that
    > header too.

    Exactly. I've seen a real failure, though.

    Thanks,
    Rafael


    \
     
     \ /
      Last update: 2011-07-28 23:09    [W:0.022 / U:31.112 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site