Messages in this thread | | | Subject | Re: [PATCH] [64/99] Revert "iwlagn: Support new 5000 microcode." | From | "Guy, Wey-Yi" <> | Date | Thu, 28 Jul 2011 06:45:33 -0700 |
| |
On Thu, 2011-07-28 at 01:24 -0700, Stanislaw Gruszka wrote: > On Wed, Jul 27, 2011 at 02:49:03PM -0700, Andi Kleen wrote: > > 2.6.35-longterm review patch. If anyone has any objections, please let me know. > > > > ------------------ > > This reverts commit 6f63415fc1b690cb50c2ad48ba6e9e6e88e271b4. > > > > It turns out this is not what we want to have happen for the .32 and > > .33-longterm kernels as it does not work properly at all. > > Hmm, it does not work on .32 and .33 because they do not contain > the commit (which 2.6.35 has): > > commit dd7a2509b3a79b290730a9c6a784bf03fedabb9a > Author: Johannes Berg <johannes.berg@intel.com> > Date: Wed Apr 28 23:33:10 2010 -0700 > > iwlagn: implement loading a new firmware file type > > > This was reported by Gentoo, Arch, and Canonical developers as causing > > problems for their users: > > https://bugs.archlinux.org/task/24302 > This is a bug about 2.6.32. > > > http://bugs.gentoo.org/show_bug.cgi?id=359445 > This looks like problem when only 8.83.5 (v5) firmware is available > on the system, but kernel is old and support only v2 version. This > should be solved by providing both old 8.24.2 (v2) and new 8.83.5 (v5) > firmware blobs in one package. > > > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/796336 > Also 2.6.32 case. > > There could be reasons for this change, but I do not see them here. > The -5 version of firmware has addition TLV information in the firmware file which provide the firmware capabilities to the driver. it is important feature starting from -5 version of firmware; and it require driver to parsing the new file type.
just like Gruszka mention, please include commit dd7a2509b3a79b290730a9c6a784bf03fedabb9a
Thanks
Wey
| |