Messages in this thread | | | Date | Thu, 28 Jul 2011 15:13:51 +0200 | From | Takashi Iwai <> | Subject | Re: [PATCH 5/6] sound/core/pcm_compat.c: adjust array index |
| |
At Thu, 28 Jul 2011 14:46:05 +0200, Julia Lawall wrote: > > From: Julia Lawall <julia@diku.dk> > > Convert array index from the loop bound to the loop index. > > A simplified version of the semantic patch that fixes this problem is as > follows: (http://coccinelle.lip6.fr/) > > // <smpl> > @@ > expression e1,e2,ar; > @@ > > for(e1 = 0; e1 < e2; e1++) { <... > ar[ > - e2 > + e1 > ] > ...> } > // </smpl> > > Signed-off-by: Julia Lawall <julia@diku.dk>
Thanks, applied now.
Takashi
> > --- > Not tested. > > sound/core/pcm_compat.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff -u -p a/sound/core/pcm_compat.c b/sound/core/pcm_compat.c > --- a/sound/core/pcm_compat.c > +++ b/sound/core/pcm_compat.c > @@ -342,7 +342,7 @@ static int snd_pcm_ioctl_xfern_compat(st > kfree(bufs); > return -EFAULT; > } > - bufs[ch] = compat_ptr(ptr); > + bufs[i] = compat_ptr(ptr); > bufptr++; > } > if (dir == SNDRV_PCM_STREAM_PLAYBACK) >
| |