lkml.org 
[lkml]   [2011]   [Jul]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 5/6] trace: Add tracepoints to call function interrupt handlers
From
Date
On Wed, 2011-07-27 at 11:57 -0700, Vaibhav Nagarnaik wrote:
> @@ -172,6 +173,7 @@ void generic_smp_call_function_interrupt(void)
> struct call_function_data *data;
> int cpu = smp_processor_id();
>
> + trace_call_function_ipi_entry(0);
> /*
> * Shouldn't receive this interrupt on a cpu that is not yet online.
> */
> @@ -239,7 +241,7 @@ void generic_smp_call_function_interrupt(void)
>
> csd_unlock(&data->csd);
> }
> -
> + trace_call_function_ipi_exit(0);
> }
>
> /*
> @@ -252,6 +254,7 @@ void generic_smp_call_function_single_interrupt(void)
> unsigned int data_flags;
> LIST_HEAD(list);
>
> + trace_call_function_single_ipi_entry(0);
> /*
> * Shouldn't receive this interrupt on a cpu that is not yet online.
> */
> @@ -282,6 +285,7 @@ void generic_smp_call_function_single_interrupt(void)
> if (data_flags & CSD_FLAG_LOCK)
> csd_unlock(data);
> }
> + trace_call_function_single_ipi_exit(0);
> }

The problem with this is that some archs only have a single IPI and
multiplex all IPIs on top, in that case you're either nesting interrupt
tracepoints or missing a part.

I really think you're doing this at the wrong level.



\
 
 \ /
  Last update: 2011-07-28 14:15    [W:0.300 / U:0.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site