Messages in this thread | | | Date | Wed, 27 Jul 2011 20:12:09 +0200 | Subject | Re: [PATCH 2/3] regulator: tps65023: Setting correct core regulator for tps65021 | From | Marcus Folkesson <> |
| |
2011/7/27 Mark Brown <broonie@opensource.wolfsonmicro.com>: > On Wed, Jul 27, 2011 at 12:32:46PM +0200, Marcus Folkesson wrote: >> TPS65023 is using VDCDC1 as core regulator and TPS65021 is using VDCDC3. > > What is "core regulator" to the regulator chip itself?
The tps6502x has 3 step down converters, VDCDC[1-3], which two has fixed voltages and the third is adjustable with the i2c interface. The adjustable converter is for controlling the core-voltage to a processor and is referred as "core" in the datasheet. Therefore a "core regulator".
A better name for "core regulator" should be "core converter" or something. I'm apologize for the confusing name.
>> Core-regulator, voltage-tables and size of voltage-table may differ between >> different regulators. All those three is now passed as driver data. > > No, the driver should be able to figure out for itself what regulators > are on the chip purely by knowing what chip it's talking to. If there > is some configuration on the board from selection of passives or similar > the platform data should reflect how that's done (eg, supply the > relevant values for the passives). >
The information is passed by the driver_data field in the device table, so the driver itself knows what chip it is talking to. In the original driver, only the voltage table was passed this way, I just added the "core_regulator" and the size of voltage-table in the same way. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |