lkml.org 
[lkml]   [2011]   [Jul]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 3/5] mm: writeback: remove seriously stale comment on dirty limits
On Mon 25-07-11 22:19:17, Johannes Weiner wrote:
> From: Johannes Weiner <hannes@cmpxchg.org>
>
> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>

Indeed outdated a lot.

Reviewed-by: Michal Hocko <mhocko@suse.cz>
if it makes any sense for comment removal like this.

> ---
> mm/page-writeback.c | 18 ------------------
> 1 files changed, 0 insertions(+), 18 deletions(-)
>
> diff --git a/mm/page-writeback.c b/mm/page-writeback.c
> index a4de005..41dc871 100644
> --- a/mm/page-writeback.c
> +++ b/mm/page-writeback.c
> @@ -379,24 +379,6 @@ int bdi_set_max_ratio(struct backing_dev_info *bdi, unsigned max_ratio)
> EXPORT_SYMBOL(bdi_set_max_ratio);
>
> /*
> - * Work out the current dirty-memory clamping and background writeout
> - * thresholds.
> - *
> - * The main aim here is to lower them aggressively if there is a lot of mapped
> - * memory around. To avoid stressing page reclaim with lots of unreclaimable
> - * pages. It is better to clamp down on writers than to start swapping, and
> - * performing lots of scanning.
> - *
> - * We only allow 1/2 of the currently-unmapped memory to be dirtied.
> - *
> - * We don't permit the clamping level to fall below 5% - that is getting rather
> - * excessive.
> - *
> - * We make sure that the background writeout level is below the adjusted
> - * clamping level.
> - */
> -
> -/*
> * global_dirty_limits - background-writeback and dirty-throttling thresholds
> *
> * Calculate the dirty thresholds based on sysctl parameters
> --
> 1.7.6
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

--
Michal Hocko
SUSE Labs
SUSE LINUX s.r.o.
Lihovarska 1060/12
190 00 Praha 9
Czech Republic


\
 
 \ /
  Last update: 2011-07-27 15:41    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site