lkml.org 
[lkml]   [2011]   [Jul]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [RFC/PATCH] mm/futex: Fix futex writes on archs with SW tracking of dirty & young
    Date
    Peter Zijlstra <peterz@infradead.org> wrote:

    > > What should nommu do anyways ? it's not like there's much it can do
    > > right ? It should never even hit the fault path to start with ...
    >
    > Something like the below makes a nommu arm config build.. David, is this
    > indeed the correct thing to do for nommu?
    >
    > ---
    > Index: linux-2.6/mm/nommu.c
    > ===================================================================
    > --- linux-2.6.orig/mm/nommu.c
    > +++ linux-2.6/mm/nommu.c
    > @@ -190,6 +190,12 @@ int get_user_pages(struct task_struct *t
    > }
    > EXPORT_SYMBOL(get_user_pages);
    >
    > +int fixup_user_fault(struct task_struct *tsk, struct mm_struct *mm,
    > + unsigned long address, unsigned int fault_flags)
    > +{
    > + BUG(); /* nommu should never call this */
    > +}
    > +
    > /**
    > * follow_pfn - look up PFN at a user virtual address
    > * @vma: memory mapping

    Or perhaps send SEGV? Can 'address' be bad at this point?

    Can you inline this for the NOMMU case please?

    David


    \
     
     \ /
      Last update: 2011-07-27 12:13    [W:3.626 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site