Messages in this thread | | | Date | Wed, 27 Jul 2011 11:52:48 +0200 | From | Samuel Ortiz <> | Subject | Re: [PATCH] mfd: avoid two assignments if failures happen in tps65910_i2c_probe |
| |
Hi Jesper,
On Wed, Jul 13, 2011 at 11:22:26PM +0200, Jesper Juhl wrote: > In drivers/mfd/tps65910.c:tps65910_i2c_probe() there's potential for a > tiny optimization. > > We assign to init_data->irq and init_data->irq_base long before we > need them, and there are two potential exits from the function before > they are needed. > > Moving the assignments below these two potential exits means we > completely avoid doing them in these two (failure) cases. Patch applied, thanks.
Cheers, Samuel.
-- Intel Open Source Technology Centre http://oss.intel.com/
| |