Messages in this thread | | | From | Bart Van Assche <> | Date | Tue, 26 Jul 2011 09:26:44 +0200 | Subject | Re: [PATCH 16/25] dynamic_debug: require 'a' flag to explicitly mark pending queries |
| |
On Mon, Jul 25, 2011 at 11:42 PM, Jim Cromie <jim.cromie@gmail.com> wrote: > + if (!q1->module ^ !q2->module || > + !q1->filename ^ !q2->filename || > + !q1->function ^ !q2->function || > + !q1->format ^ !q2->format) > + return false; /* a match-spec set/unset state differs */
I'd suggest to use "!=" here instead of "^" when testing booleans for inequality. At least for me that would make the above code easier to read.
Bart. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |