Messages in this thread |  | | | Date | Wed, 27 Jul 2011 08:34:55 +0900 | | Subject | Re: [PATCH -mmotm] fault-injection: add ability to export fault_attr in arbitrary directory | | From | Akinobu Mita <> |
| |
2011/7/27 Andrew Morton <akpm@linux-foundation.org>: > On Wed, 27 Jul 2011 08:06:37 +0900 > Akinobu Mita <akinobu.mita@gmail.com> wrote: > >> init_fault_attr_dentries() is used to export fault_attr via debugfs. But >> it can only export it in debugfs root directory. >> >> Per Forlin is working on mmc_fail_request which adds support to inject >> data errors after a completed host transfer in MMC subsystem. >> >> The fault_attr for mmc_fail_request should be defined per mmc host and >> export it in debugfs directory per mmc host like >> /sys/kernel/debug/mmc0/mmc_fail_request. >> >> init_fault_attr_dentries() doesn't help for mmc_fail_request. So this >> introduces debugfs_create_fault_attr() which is able to create a directory >> in the arbitrary directory and replace init_fault_attr_dentries(). > > The name is wrong. "debugfs_create_fault_attr" refers to some function > exported by the debugfs code. But this function is exported by the > fault injection code. > > I edited the patch and renamed it to fault_create_debugfs_attr, which > may not make a ton of sense - please let me know if there's something > more appropriate.
Thanks for spotting the problem and the new function name sounds good.
> I suggest that all symbols exported by this system should start with > "fault_". ("fault_injection_" would be more appropriate, but it's > rather lengthy). Please take a look through the code, see if there's > anything else we should clean up.
OK, I'll check that. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |