lkml.org 
[lkml]   [2011]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] printk: add Kconfig for default console loglevel
On Tue, 26 Jul 2011 11:33:51 -0400 Dave Reisner wrote:

> Keep the historical default of 7, but allow distributions and users to
> tune this value instead of requiring a kernel cmdline parameter.

Hi,

Please explain how this is different from what is already in lib/Kconfig.debug:

config DEFAULT_MESSAGE_LOGLEVEL
int "Default message log level (1-7)"
range 1 7
default "4"
help
Default log level for printk statements with no specified priority.


> Signed-off-by: Dave Reisner <dreisner@archlinux.org>
> ---
> kernel/printk.c | 4 +++-
> lib/Kconfig.debug | 10 ++++++++++
> 2 files changed, 13 insertions(+), 1 deletions(-)
>
> diff --git a/kernel/printk.c b/kernel/printk.c
> index 37dff34..fabc216 100644
> --- a/kernel/printk.c
> +++ b/kernel/printk.c
> @@ -58,7 +58,9 @@ void asmlinkage __attribute__((weak)) early_printk(const char *fmt, ...)
>
> /* We show everything that is MORE important than this.. */
> #define MINIMUM_CONSOLE_LOGLEVEL 1 /* Minimum loglevel we let people use */
> -#define DEFAULT_CONSOLE_LOGLEVEL 7 /* anything MORE serious than KERN_DEBUG */
> +
> +/* default to 7 -- anything MORE serious than KERN_DEBUG */
> +#define DEFAULT_CONSOLE_LOGLEVEL CONFIG_DEFAULT_CONSOLE_LOGLEVEL
>
> DECLARE_WAIT_QUEUE_HEAD(log_wait);
>
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index c0cb9c4..6caa66e 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -21,6 +21,16 @@ config DEFAULT_MESSAGE_LOGLEVEL
> that are auditing their logs closely may want to set it to a lower
> priority.
>
> +config DEFAULT_CONSOLE_LOGLEVEL
> + int "Default console log level (1-7)"
> + range 1 7
> + default "7"
> + help
> + Default console log level setting for printk statements.
> +
> + This was hard-coded to KERN_INFO (7) since at least 2.6.12. You may
> + wish to turn this down to 4 for a quieter console.
> +
> config ENABLE_WARN_DEPRECATED
> bool "Enable __deprecated logic"
> default y
> --


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***


\
 
 \ /
  Last update: 2011-07-26 18:39    [W:0.262 / U:0.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site