Messages in this thread | | | Date | Tue, 26 Jul 2011 12:08:04 +0200 | From | Olivier Galibert <> | Subject | Re: [GIT PULL] iscsi-target merge for v3.1-rc1 |
| |
On Tue, Jul 26, 2011 at 12:09:40AM -0700, Linus Torvalds wrote: > And it just looks unnecessarily complicated. Just a simple > > #define DIV_ROUND_UP_ULL(ll,d) \ > ({ unsigned long long _tmp = (ll)+(d)-1; do_div(_tmp, d); _tmp; }) > > looks like it would work and be simpler. Avoid the conditional, do the > same "add 'd-1' thing as the regular ROUND_UP(). > > Untested. And not much thinking involved.
Overflow risk? Of course DIV_ROUND_UP has the same issue, and looks slight easier to trigger, maybe.
OG.
| |