Messages in this thread | | | Date | Tue, 26 Jul 2011 07:56:12 +0900 | Subject | Re: [patch 1/5] mm: page_alloc: increase __GFP_BITS_SHIFT to include __GFP_OTHER_NODE | From | Minchan Kim <> |
| |
On Tue, Jul 26, 2011 at 5:19 AM, Johannes Weiner <jweiner@redhat.com> wrote: > From: Johannes Weiner <hannes@cmpxchg.org> > > __GFP_OTHER_NODE is used for NUMA allocations on behalf of other > nodes. It's supposed to be passed through from the page allocator to > zone_statistics(), but it never gets there as gfp_allowed_mask is not > wide enough and masks out the flag early in the allocation path. > > The result is an accounting glitch where successful NUMA allocations > by-agent are not properly attributed as local. > > Increase __GFP_BITS_SHIFT so that it includes __GFP_OTHER_NODE. > > Signed-off-by: Johannes Weiner <hannes@cmpxchg.org> Reviewed-by: Minchan Kim <minchan.kim@gmail.com>
Nice catch.
-- Kind regards, Minchan Kim -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |