lkml.org 
[lkml]   [2011]   [Jul]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 3/3] dmaengine: at_hdmac: add slave config operation
    On 07/07/2011 04:33 AM, Vinod Koul wrote:
    > On Tue, 2011-06-28 at 13:17 +0200, Nicolas Ferre wrote:
    >> Only change source/destination peripheral register access width.
    > How about a little more explainable change log
    >
    >>
    >> Signed-off-by: Nicolas Ferre<nicolas.ferre@atmel.com>
    >> Signed-off-by: Uwe Kleine-König<u.kleine-koenig@pengutronix.de>
    >> ---
    >> drivers/dma/at_hdmac.c | 29 +++++++++++++++++++++++++++++
    >> 1 files changed, 29 insertions(+), 0 deletions(-)
    >>
    >> diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c
    >> index 7096adb..9cb8044 100644
    >> --- a/drivers/dma/at_hdmac.c
    >> +++ b/drivers/dma/at_hdmac.c
    >> @@ -954,6 +954,35 @@ static int atc_control(struct dma_chan *chan, enum dma_ctrl_cmd cmd,
    >> clear_bit(ATC_IS_PAUSED,&atchan->status);
    >>
    >> spin_unlock_irqrestore(&atchan->lock, flags);
    >> + } else if (cmd == DMA_SLAVE_CONFIG) {
    >> + struct dma_slave_config *dmaengine_cfg = (void *)arg;
    >> + struct at_dma_slave *atslave = chan->private;
    > This API was created to remove chan->private, so this doesn't make sense
    > at all. If your intent is to have a channels internal data, then you
    > should consider embedding dma_chan into this structure (the way other
    > dma drivers do) rather than using private field.

    Yes, I need to rework this slave config part of the driver (and its
    related calling drivers).

    So please drop this 3/3 patch of the series.

    Best regards,
    --
    Nicolas Ferre
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-07-25 23:15    [W:0.044 / U:96.104 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site