lkml.org 
[lkml]   [2011]   [Jul]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch 1/3] rtc: Handle errors correctly in rtc_irq_set_state()
    On Fri, 22 Jul 2011, Andrew Morton wrote:

    > On Fri, 22 Jul 2011 09:12:50 -0000
    > Thomas Gleixner <tglx@linutronix.de> wrote:
    >
    > > The code checks the correctness of the parameters, but unconditionally
    > > arms/disarms the hrtimer.
    > >
    > > Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
    > > Cc: stable@kernel.org
    >
    > The -stable maintainers will want to know why they should merge this.
    >
    > The maintainers of other trees will wonder whether they should backport
    > it too.
    >
    > To help them make these decision we should always provide a description
    > of the user-visible effects of the bug, please.

    Fair enough.

    The result is that a random task might arm/disarm rtc timer and
    surprise the real owner by either generating events or by stopping
    them. Both undesired behaviour :)


    \
     
     \ /
      Last update: 2011-07-23 09:19    [W:0.025 / U:29.780 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site