Messages in this thread | | | Date | Fri, 22 Jul 2011 21:26:10 +0200 | From | Wim Van Sebroeck <> | Subject | Re: [PATCH 04/11] watchdog: WatchDog Timer Driver Core - Add WDIOC_SETOPTIONS ioctl |
| |
Hi Wolfram,
> > @@ -168,7 +233,7 @@ static int watchdog_open(struct inode *inode, struct file *file) > > goto out; > > > > /* start the watchdog */ > > - err = wdd->ops->start(wdd); > > + err = watchdog_start(wdd); > > I think we still might need open- and close-callbacks here. Some drivers turn > on/off clocks on these operations and we can't simply move them to the > start/stop callbacks, because the clock might be turned off via DISABLECARD > which calls stop. And without the clock, a simple register access via > set_timeout might lock up the machine.
I consider that an extension on the basic framework. After these patches are accepted we can work on this.
Kind regards, Wim.
| |