Messages in this thread Patch in this message | | | Date | Thu, 21 Jul 2011 10:09:19 GMT | From | tip-bot for Jean Delvare <> | Subject | [tip:core/locking] mutex: Make mutex_destroy() an inline function |
| |
Commit-ID: 4582c0a4866ea70c35aa9279e1f91834d3348a93 Gitweb: http://git.kernel.org/tip/4582c0a4866ea70c35aa9279e1f91834d3348a93 Author: Jean Delvare <khali@linux-fr.org> AuthorDate: Sat, 16 Jul 2011 17:42:00 +0200 Committer: Ingo Molnar <mingo@elte.hu> CommitDate: Thu, 21 Jul 2011 09:36:09 +0200
mutex: Make mutex_destroy() an inline function
The non-debug variant of mutex_destroy is a no-op, currently implemented as a macro which does nothing. This approach fails to check the type of the parameter, so an error would only show when debugging gets enabled. Using an inline function instead, offers type checking for earlier bug catching.
Signed-off-by: Jean Delvare <khali@linux-fr.org> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Link: http://lkml.kernel.org/r/20110716174200.41002352@endymion.delvare Signed-off-by: Ingo Molnar <mingo@elte.hu> --- include/linux/mutex.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/linux/mutex.h b/include/linux/mutex.h index a940fe4..7f87217 100644 --- a/include/linux/mutex.h +++ b/include/linux/mutex.h @@ -92,7 +92,7 @@ do { \ \ __mutex_init((mutex), #mutex, &__key); \ } while (0) -# define mutex_destroy(mutex) do { } while (0) +static inline void mutex_destroy(struct mutex *lock) {} #endif #ifdef CONFIG_DEBUG_LOCK_ALLOC
| |