Messages in this thread | | | Subject | Re: [regression] 3.0-rc boot failure -- bisected to cd4ea6ae3982 | From | Peter Zijlstra <> | Date | Wed, 20 Jul 2011 12:45:08 +0200 |
| |
On Wed, 2011-07-20 at 20:14 +1000, Anton Blanchard wrote:
> > That looks very strange indeed.. up to node 23 there is the normal > > symmetric matrix with all the trace elements on 10 (as we would expect > > for local access), and some 4x4 sub-matrix stacked around the trace > > with 20, suggesting a single hop distance, and the rest on 40 being > > out-there. > > I retested with the latest version of numactl, and get correct results.
One less thing to worry about ;-)
> I worked out why the patches don't boot, we weren't allocating any > space for the cpumask and ran off the end of the allocation.
Gah! that's not the first time I made that particular mistake :/
> Should we also use cpumask_copy instead of open coding it? I added that > too.
Probably, I looked for cpumask_assign() and on failing to find that used the direct assignment.
So with that fix the patch makes the machine happy again?
Thanks!
| |