lkml.org 
[lkml]   [2011]   [Jul]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/2] asm-generic: add MMU variants of io.h functions
From
Date

On Sat, 2011-07-02 at 12:38 -0400, Mike Frysinger wrote:
> On Sat, Jul 2, 2011 at 11:53, Jonas Bonn wrote:
> > Some of the implementations, in particular the ioremap variants, in
> > asm-generic/io.h are for systems with an MMU.
>
> do you mean "without an MMU" ?

Yes, of course... that's supposed to be _without_ an MMU.

>
> > +#ifdef CONFIG_MMU
> > +#define xlate_dev_mem_ptr(p) __va(p)
> > +#else
> > #define xlate_dev_mem_ptr(p) ((void *) (p))
> > +#endif
>
> i wonder if we could do:
> #ifndef __va
> #define __va(p) ((void *)(p))
> #endif
> #define xlate_dev_mem_ptr(p) __va(p)
> -mike

This seems to introduce an artificial definition of a "virtual" address
for systems without an MMU, which strikes me as a bit odd. If this is
what people prefer, that's fine... I think I prefer the former variant,
though.

/Jonas



\
 
 \ /
  Last update: 2011-07-02 18:49    [W:0.060 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site