lkml.org 
[lkml]   [2011]   [Jul]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [patch 03/11] blackfin/irqs: Do not trace arch_local_{*,irq_*} functions
On Sat, Jul 2, 2011 at 12:11, Steven Rostedt wrote:
> On Sat, 2011-07-02 at 02:50 -0400, Mike Frysinger wrote:
>> On Fri, Jul 1, 2011 at 23:04, Steven Rostedt wrote:
>> > Do not trace arch_local_save_flags(), arch_local_irq_*() and friends.
>> > Although they are marked inline, gcc may still make a function out of
>> > them and add it to the pool of functions that are traced by the function
>> > tracer. This can cause undesirable results (kernel panic, triple faults,
>> > etc).
>> >
>> > Add the notrace notation to prevent them from ever being traced.
>>
>> what about putting the markings in include/asm-generic/irqflags.h ?
>> then you wouldnt have to update every arch (or at least, not as much).
>
> One of my patches do that, but it only helps superH, as that's the only
> arch that uses that header and implements function tracing.

hmm, i thought Blackfin was using that too. guess i'll have to fix that ;).
-mike


\
 
 \ /
  Last update: 2011-07-02 18:43    [W:0.045 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site