lkml.org 
[lkml]   [2011]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRE: [PATCH 2/3] dt: tegra20: Add ehci host controller nodes.
achew@nvidia.com wrote at Tuesday, July 19, 2011 4:47 PM:
> From: Andrew Chew <achew@nvidia.com>
>
> These values were derived from various headers in arch/arm/mach-tegra.
>
> Signed-off-by: Andrew Chew <achew@nvidia.com>
> ---
> arch/arm/boot/dts/tegra20.dtsi | 52 ++++++++++++++++++++++++++++++++++++++++
> 1 files changed, 52 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/boot/dts/tegra20.dtsi b/arch/arm/boot/dts/tegra20.dtsi
> index 83fedf3..a0353bb 100644
> --- a/arch/arm/boot/dts/tegra20.dtsi
> +++ b/arch/arm/boot/dts/tegra20.dtsi
> @@ -160,5 +160,57 @@
> interrupts = < 63 >;
> status = "disabled";
> };
> +
> + ehci@c5000000 {
> + #address-cells = <1>;
> + #size-cells = <0>;

I don't think those two properties are needed for an EHCI node; children
of the EHCI controller are probed rather than specified in device tree.

> + compatible = "nvidia,tegra20-ehci";
> + reg = <0xc5000000 0x4000>;
> + interrupts = < 52 >;
> + mode = < 1 >;

Should we make mode a string; device, host, or otg?

> + power_down_on_bus_suspend;
> + type = "utmi";
> + hssync_start_delay = < 0 >;
> + idle_wait_delay = < 17 >;
> + elastic_limit = < 16 >;
> + term_range_adj = < 6 >;
> + xcvr_setup = < 15 >;
> + xcvr_lsfslew = < 2 >;
> + xcvr_lsrslew = < 2 >;
> + status = "disabled";

In the latest devicetree/test, tegra20.dtsi doesn't specify status for
any nodes, but leaves everything enabled. Instead, board-specific files
disable any unused devices.

> + };
> +
> + ehci@c5004000 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + compatible = "nvidia,tegra20-ehci";
> + reg = <0xc5004000 0x4000>;
> + interrupts = < 53 >;
> + mode = < 1 >;
> + power_down_on_bus_suspend;
> + type = "ulpi";
> + reset_gpio = < 169 >;
> + clk = "cdev2";
> + status = "disabled";
> + };
> +
> + ehci@c5008000 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + compatible = "nvidia,tegra20-ehci";
> + reg = <0xc5008000 0x4000>;
> + interrupts = < 129 >;
> + mode = < 1 >;
> + power_down_on_bus_suspend;
> + type = "utmi";
> + hssync_start_delay = < 0 >;
> + idle_wait_delay = < 17 >;
> + elastic_limit = < 16 >;
> + term_range_adj = < 6 >;
> + xcvr_setup = < 8 >;
> + xcvr_lsfslew = < 2 >;
> + xcvr_lsrslew = < 2 >;
> + status = "disabled";
> + };
> };
>
> --
> 1.7.6

--
nvpublic



\
 
 \ /
  Last update: 2011-07-20 01:03    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site