Messages in this thread | | | Subject | Re: [PATCH 5/8] Staging: hv: mousevsc: Fix checkpatch errors and warnings | From | Joe Perches <> | Date | Tue, 19 Jul 2011 12:28:33 -0700 |
| |
On Tue, 2011-07-19 at 11:44 -0700, K. Y. Srinivasan wrote: > Fix checkpatch errors and warnings. [] > diff --git a/drivers/staging/hv/hv_mouse.c b/drivers/staging/hv/hv_mouse.c [] > @@ -53,7 +53,7 @@ struct hv_input_dev_info { > -#pragma pack(push,1) > +#pragma pack(push, 1) > /* > * Message types in the synthetic input protocol > */
Perhaps it's better and more consistent with other kernel style uses to remove #pragma pack[...] and mark the individual structs with __packed;
$ grep -rP --include=*.[ch] "pragma.*pack" * | wc -l 221 $ grep -rP --include=*.[ch] "(__attribute__.*packed|\b__packed\b)" * | wc -l 5553
| |