Messages in this thread | | | Subject | Re: [PATCH 11/11] dynamic_debug: use a single printk() to emit msgs | From | Joe Perches <> | Date | Fri, 15 Jul 2011 09:16:20 -0700 |
| |
On Fri, 2011-07-15 at 18:10 +0200, Bart Van Assche wrote: > On Fri, Jul 15, 2011 at 6:04 PM, Jason Baron <jbaron@redhat.com> wrote: > > yes, but that approach uses 'KERN_CONT'. The point of patch 11/11 is to get rid > > of KERN_CONT, which is racy. > I know. What I'm trying to explain is that since patch 11/11 modifies > dynamic_emit_prefix() such that it writes its output to a buffer there > is no longer a need to write into that buffer with a single snprintf() > call. Using multiple snprintf() calls is also fine. Hence it is > possible to eliminate the two temporary arrays (tid[] and lineno[]) > from dynamic_emit_prefix() without reintroducing these races.
Ah, just so. It's so easy to be narrow minded.
Jason, you are going to do this yes?
cheers, Joe
| |