Messages in this thread | | | Date | Fri, 15 Jul 2011 14:09:44 +0900 | From | Mark Brown <> | Subject | Re: [PATCH 3/4] regmap: Add SPI bus support |
| |
On Thu, Jul 14, 2011 at 11:04:27PM -0600, Grant Likely wrote: > On Thu, Jul 14, 2011 at 10:39 PM, Mark Brown > <broonie@opensource.wolfsonmicro.com> wrote:
[Regmap API I2C bus code.] > > There was a bit about this in the cover mail - it's the interace > > stability issue again, the plan is to move them once we're more > > confident that the interface used will stay stable.
> I've got no problem with churn in drivers/spi, and I'm fine to have > changes in drivers/spi merged via other trees if it means the code is > in the logical place.
Can I add an ack from you for that? If/when it does get merged I'd appreciate it if you pushed any code to me for review.
> >> struct spi_transfer t[2] = { {.tx_buf = reg, .len = reg_len}, > >> {.tx_buf = val, .len = val_len}};
> >> Then the memset() and t[0]/t[1] lines can all be culled.
> > That does the init to zero?
> You might want to double check, but I believe it gets implemented as a > memcpy of a static initializer.
Hrm, given that neither of us is 100% sure I think it's safer to leave it written out long hand and avoid confusing anyone else. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |