lkml.org 
[lkml]   [2011]   [Jul]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] genirq: don't use flush_scheduled_work() in IRQ affinity notifiers
From
Date
On Fri, 2011-06-17 at 11:45 +0200, Tejun Heo wrote:
> Hello,
>
> On Fri, Jun 17, 2011 at 12:28:06AM +0100, Ben Hutchings wrote:
> > This facility is enabled on all configurations with NET && SMP &&
> > GENERIC_HARDIRQS, but at the moment is only useful for some net drivers
> > (currently only one). So I don't think it should be creating a task at
> > boot time. Does alloc_workqueue() still create any tasks immediately?
>
> Nope, no need to worry about it. The only added overhead is the
> memory occupied by workqueue itself (which includes small percpu area
> but one systemwide one isn't gonna hurt anyone and we've been
> decreasing the number of workqueues significantly). It just serves as
> a flush domain.

Sorry I didn't reply to this earlier.

Given what you've said, I see no problem with this change. So you can
add:

Acked-by: Ben Hutchings <bhutchings@solarflare.com>

Ben.

--
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.



\
 
 \ /
  Last update: 2011-07-14 18:51    [W:0.358 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site