lkml.org 
[lkml]   [2011]   [Jul]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH next/mmotm] slub: partly fix freeze in __slab_free
On Wed, 13 Jul 2011, Christoph Lameter wrote:
>
> Subject: slub: disable interrupts in cmpxchg_double_slab when falling back to pagelock.
>
> Disable interrupts when falling back to the use of the page lock in
> cmpxchg_double_slab().
>
> Becomes necessary since __slab_free will call cmpxchg_double_slab without disabling
> interrupts.
>
> A bit bad because the invocations from the allocation path of cmpxchg_double_slab
> occur with interrupts already disabled (but there are plans to enable
> interrupts there as well in the future).
>
> Signed-off-by: Christoph Lameter <cl@linux.com>

Success, thank you: I ran my load for 22 hours on the ppc64,
no problem this time, where before it froze in 2.5 hours.

I was running rc6-mm1 plus this patch, plus (my transcription of) your
mm_types.h struct page patch, plus Fengguang's redirty_tail patch;
leaving out my "*new = page" patch which kicked this thread off.

Feel free to add
Tested-by: Hugh Dickins <hughd@google.com>

>
>
> ---
> mm/slub.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> Index: linux-2.6/mm/slub.c
> ===================================================================
> --- linux-2.6.orig/mm/slub.c 2011-07-13 10:51:07.867138834 -0500
> +++ linux-2.6/mm/slub.c 2011-07-13 10:51:20.957138752 -0500
> @@ -368,14 +368,19 @@ static inline bool cmpxchg_double_slab(s
> } else
> #endif
> {
> + unsigned long flags;
> +
> + local_irq_save(flags);
> slab_lock(page);
> if (page->freelist == freelist_old && page->counters == counters_old) {
> page->freelist = freelist_new;
> page->counters = counters_new;
> slab_unlock(page);
> + local_irq_restore(flags);
> return 1;
> }
> slab_unlock(page);
> + local_irq_restore(flags);
> }
>
> cpu_relax();
>


\
 
 \ /
  Last update: 2011-07-14 18:17    [W:0.055 / U:0.448 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site