Messages in this thread | | | Subject | Re: [PATCH] checkpatch.pl: Update $logFunctions | From | Joe Perches <> | Date | Wed, 13 Jul 2011 16:41:56 -0700 |
| |
On Wed, 2011-07-13 at 16:16 -0700, Andrew Morton wrote: > On Wed, 13 Jul 2011 09:05:47 -0700 > Joe Perches <joe@perches.com> wrote: > > Allow numbers in leading prefix. > > Add logging functions with _once and _ratelimit. > > Add <prefix>_printk. > I look at this description wondering "hm, what does this do to > checkpatch behaviour" and realize I have not a clue. > Oh well, I'll trust you ;)
Not necessarily a good plan...
Perhaps this description instead:
[PATCH] checkpatch.pl: Allow more printk types (<prefix>_<level>) to be > 80 cols
Previous behavior allowed only alphabetic prefixes like pr_info to exceed the 80 column line length limit.
ath6kl wants to add a digit into the prefix, so allow numbers as well as digits in the <prefix>_<level> printks.
<prefix>_<level>_ratelimited and <prefix>_<level>_once and WARN_RATELIMIT and WARN_ONCE may now exceed 80 cols.
Add missing <prefix>_printk type for completeness.
| |