lkml.org 
[lkml]   [2011]   [Jul]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 2/3] PM / Domains: Take .power_off() error code into account
    Date
    From: Rafael J. Wysocki <rjw@sisk.pl>

    Currently pm_genpd_poweroff() discards error codes returned by
    the PM domain's .power_off() callback, because it's safer to always
    regard the domain as inaccessible to drivers after a failing
    .power_off(). Still, there are situations in which the low-level
    code may want to indicate that it doesn't want to power off the
    domain, so allow it to do that by returning -EBUSY from .power_off().

    Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
    ---
    drivers/base/power/domain.c | 12 ++++++++++--
    1 file changed, 10 insertions(+), 2 deletions(-)

    Index: linux-2.6/drivers/base/power/domain.c
    ===================================================================
    --- linux-2.6.orig/drivers/base/power/domain.c
    +++ linux-2.6/drivers/base/power/domain.c
    @@ -312,8 +312,16 @@ static int pm_genpd_poweroff(struct gene
    }
    }

    - if (genpd->power_off)
    - genpd->power_off(genpd);
    + if (genpd->power_off) {
    + ret = genpd->power_off(genpd);
    + if (ret == -EBUSY) {
    + genpd_set_active(genpd);
    + if (parent)
    + genpd_release_lock(parent);
    +
    + goto out;
    + }
    + }

    genpd->status = GPD_STATE_POWER_OFF;



    \
     
     \ /
      Last update: 2011-07-13 23:59    [W:0.021 / U:2.712 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site