Messages in this thread |  | | | Subject | Re: [RFT][PATCH] sched, cgroup: Optimize load_balance_fair() | | From | Peter Zijlstra <> | | Date | Wed, 13 Jul 2011 23:02:48 +0200 |
| |
On Wed, 2011-07-13 at 10:13 -0700, Paul Turner wrote: > Nice! The continued usage of task_groups had been irking me for a > while but I haven't had the time to scratch the itch :). > > On Wed, Jul 13, 2011 at 4:36 AM, Peter Zijlstra <peterz@infradead.org> wrote: > > Subject: sched, cgroup: Optimize load_balance_fair() > > From: Peter Zijlstra <a.p.zijlstra@chello.nl> > > Date: Wed Jul 13 13:09:25 CEST 2011 > > > > Use for_each_leaf_cfs_rq() instead of list_for_each_entry_rcu(), this > > achieves that load_balance_fair() only iterates those task_groups that > > actually have tasks on busiest, and that we iterate bottom-up, trying to > > move light groups before the heavier ones. > > > > No idea if it will actually work out to be beneficial in practice, does > > anybody have a cgroup workload that might show a difference one way or > > the other? > > > > [ Also move update_h_load to sched_fair.c, loosing #ifdef-ery ] > > > > Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Reviewed-by: Paul Turner <pjt@google.com>
So you think I should just merge it and see if any cgroup workload dislikes it?
OK, I guess I can do that..
|  |