Messages in this thread | | | From | David Brown <> | Subject | Re: [PATCH 5/5] drivers/video/msm/mdp.c: adjust error handling code | Date | Wed, 13 Jul 2011 10:49:46 -0700 |
| |
On Wed, Jul 13 2011, Paul Mundt wrote:
>> I wonder if the error handling code at the end of the function should be >> calling clk_put as well? In that case, having a separate label for this >> case would be useful. Otherwise, one of error_request_irq and error_get_clk >> can be deleted >> > The MSM implementation for it is simply a nop, so it's not going to > really matter one way or the other. In terms of general consistency it > might be worth implementing.
Today, at least. Hopefully this will get better, since we can turn off our clocks.
David
-- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
| |