Messages in this thread | | | Date | Mon, 11 Jul 2011 17:01:22 -0700 | Subject | Re: [PATCH v4] ARM: Use generic BUG() handler | From | Simon Glass <> |
| |
[Resent, without html, sorry]
Hi Russell & Dave,
On Thu, Jul 7, 2011 at 2:28 AM, Dave Martin <dave.martin@linaro.org> wrote: > On Wed, Jul 06, 2011 at 09:06:07PM +0100, Russell King - ARM Linux wrote: >> >> Sorry, I've finally got back to looking at this. >> >> + ".pushsection .rodata.str, \"aMS\", 1\n" \ >> >> According to my gas manual: >> >> | 7.88 `.pushsection NAME [, SUBSECTION] [, "FLAGS"[, @TYPE[,ARGUMENTS]]]' >> | ... [snip] >> It appears that the TYPE argument is missing. As the GAS manual says >> its required, then I think it really ought to be there. Any comment? > > I guess type should be %progbits. That's what the compiler generates for > the assembler input in similar situations. > > Interestingly, gas does not require this argument and seems to default to > progbits anyway ... but it seems best to do what the manual says. >
Thanks for this. I will update the patch and resend to the list.
Regards, Simon
> Cheers > ---Dave > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |