Messages in this thread | | | Date | Tue, 12 Jul 2011 01:02:05 +0200 | From | Lars-Peter Clausen <> | Subject | Re: [PATCH 01/11] watchdog: WatchDog Timer Driver Core - Add basic framework |
| |
On 07/11/2011 11:32 PM, Wolfram Sang wrote:
>> +int watchdog_register_device(struct watchdog_device *wdd) >> +{ >> + int ret; >> + >> + /* Make sure we have a valid watchdog_device structure */ >> + if (wdd == NULL || wdd->info == NULL || wdd->ops == NULL) >> + return -EINVAL; >> + >> + /* Make sure that the mandatory operations are supported */ >> + if (wdd->ops->start == NULL || wdd->ops->stop == NULL) >> + return -EINVAL; > > Check also for wdd->ops->owner? Should we mark it as mandatory? >
If the driver is built-in owner will be NULL.
| |