lkml.org 
[lkml]   [2011]   [Jul]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] [RFC][PATCH] Remove /proc/kallsyms size verification check in perf
Date
The check was failing when I was trying to profile system startup
because the modules were being loaded and causing the size of
kallsyms to change. At first I changed the check to simply make
sure the size of kallsyms increased, but that wouldn't cover the
case of a module getting removed (or some removed and larger ones
loaded). I can't see any purpose to checking the size
right after reading it either, so remove the check altogether.

Signed-off-by: Sonny Rao <sonnyrao@chromium.org>
---
tools/perf/util/trace-event-info.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/tools/perf/util/trace-event-info.c b/tools/perf/util/trace-event-info.c
index 35729f4..3f1af9f 100644
--- a/tools/perf/util/trace-event-info.c
+++ b/tools/perf/util/trace-event-info.c
@@ -440,9 +440,6 @@ static void read_proc_kallsyms(void)
}
size = get_size(path);
write_or_die(&size, 4);
- check_size = copy_file(path);
- if (size != check_size)
- die("error in size of file '%s'", path);

}

--
1.7.3.1


\
 
 \ /
  Last update: 2011-07-12 01:01    [W:0.027 / U:0.584 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site