lkml.org 
[lkml]   [2011]   [Jul]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 3/3] Staging: comedi: fix brace coding style issue in pcl818.c
From
Date
On Mon, 2011-07-11 at 11:30 +0530, Ravishankar wrote:
> This is a patch to the pcl818.c file that fixes up a brace warning found by the checkpatch.pl tool
> diff --git a/drivers/staging/comedi/drivers/pcl818.c b/drivers/staging/comedi/drivers/pcl818.c
[]
> @@ -1301,11 +1301,10 @@ static void setup_channel_list(struct comedi_device *dev,
> */
> static int check_single_ended(unsigned int port)
> {
> - if (inb(port + PCL818_STATUS) & 0x20) {
> + if (inb(port + PCL818_STATUS) & 0x20)
> return 1;
> - } else {
> + else
> return 0;
> - }
> }

I'd prefer this become:

static bool check_single_ended()
{
if (...)
return true;
return false;
}




\
 
 \ /
  Last update: 2011-07-11 07:59    [W:0.033 / U:0.740 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site