lkml.org 
[lkml]   [2011]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: state machine defect in drivers/tty/vt/vt.c?
Date
Joe Perches <joe@perches.com> writes:

> vc->vc_state is sequentially set to different values.
>
> Looks like there's either a return or a break
> missing at the end of case ESgetpars:
>
> Anyone know the right fix here?

The first assignment can be removed.

> case ESgetpars:
> if (c == ';' && vc->vc_npar < NPAR - 1) {
> vc->vc_npar++;
> return;
> } else if (c>='0' && c<='9') {
> vc->vc_par[vc->vc_npar] *= 10;
> vc->vc_par[vc->vc_npar] += c - '0';
> return;
> } else
> vc->vc_state = ESgotpars;
> case ESgotpars:
> vc->vc_state = ESnormal;

That handles cases like '\033[m' where '\033[' enters state ESgetpars,
but 'm' is handled by ESgotpars.

Andreas.

--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."


\
 
 \ /
  Last update: 2011-07-10 20:15    [from the cache]
©2003-2011 Jasper Spaans