| Date | Fri, 1 Jul 2011 14:57:40 -0700 | From | Greg KH <> | Subject | Re: [PATCH 01/11] dynamic_debug: allow changing of dynamic_debug verbosity any time |
| |
On Wed, Jun 29, 2011 at 12:41:18PM +0200, Bart Van Assche wrote: > On Tue, Jun 28, 2011 at 9:09 AM, Jim Cromie <jim.cromie@gmail.com> wrote: > > allow changing dynamic_debug verbosity > > at boot-time, with: dynamic_debug.verbose=1 > > or at runtime with: > > root@voyage:~# echo 1 > /sys/module/dynamic_debug/parameters/verbose > > > > Signed-off-by: Jim Cromie <jim.cromie@gmail.com> > > --- > > lib/dynamic_debug.c | 1 + > > 1 files changed, 1 insertions(+), 0 deletions(-) > > > > diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c > > index 75ca78f..a3b08d5 100644 > > --- a/lib/dynamic_debug.c > > +++ b/lib/dynamic_debug.c > > @@ -58,6 +58,7 @@ struct ddebug_iter { > > static DEFINE_MUTEX(ddebug_lock); > > static LIST_HEAD(ddebug_tables); > > static int verbose = 0; > > +module_param(verbose, int, 0744); > > Why 0744 and not 0644 ? Why to set the 'executable' bit ?
Yeah, that's wrong, Jim, care to fix this?
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|