Messages in this thread | | | Date | Thu, 9 Jun 2011 09:18:54 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH] oprofile, x86: Fix race in nmi handler while starting |
| |
* Robert Richter <robert.richter@amd.com> wrote:
> In some rare cases, nmis are generated immediately after the nmi > handler of the cpu was started. This causes the counter not to be > enabled. Before enabling the nmi handlers we need to set variable > ctr_running first and make sure its value is written to memory. > > Also, the patch makes all existing barriers a memory barrier > instead of a compiler barrier only.
Could we *PLEASE* just do the obvious and turn oprofile into a perf user on x86 too, like ARM already does? Two years down the line and there's zero progress in that area. We want to obsolete the Oprofile PMU bits on x86, the infrastructure duplication causes non-trivial problems like this one.
Thanks,
Ingo
| |