lkml.org 
[lkml]   [2011]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v4 3.0-rc2-tip 2/22] 2: uprobes: Breakground page replacement.
From
Date
On Tue, 2011-06-07 at 18:28 +0530, Srikar Dronamraju wrote:
> + ret = anon_vma_prepare(vma);
> + if (ret)
> + goto unlock_out;

You just leaked new_page.

> +
> + lock_page(new_page);
> + ret = __replace_page(vma, old_page, new_page);
> + unlock_page(new_page);
> + if (ret != 0)
> + page_cache_release(new_page);
> +unlock_out:
> + unlock_page(old_page);
> +
> +put_out:
> + put_page(old_page); /* we did a get_page in the beginning */
> + return ret;
> +}



\
 
 \ /
  Last update: 2011-06-10 01:03    [W:0.449 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site