Messages in this thread | | | Date | Thu, 9 Jun 2011 12:33:00 -0700 | From | Arun Sharma <> | Subject | Re: [PATCH] [perf] Add inverted call graph report support. |
| |
On Thu, Jun 09, 2011 at 02:44:19PM +0800, Sam Liao wrote: > --- a/tools/perf/util/session.c > +++ b/tools/perf/util/session.c > @@ -247,9 +247,14 @@ int perf_session__resolve_callchain(struct > perf_session *self, > callchain_cursor_reset(&self->callchain_cursor); > > for (i = 0; i < chain->nr; i++) { > - u64 ip = chain->ips[i]; > + u64 ip; > struct addr_location al; > > + if (callchain_param.order == ORDER_CALLEE) > + ip = chain->ips[i]; > + else > + ip = chain->ips[chain->nr - i - 1];
This can dereference a bad pointer if chain->nr == 0.
-Arun
| |