lkml.org 
[lkml]   [2011]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 13/15] x86: Swap save_stack_trace_regs parameters
    From: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>

    Swap the 1st and 2nd parameters of save_stack_trace_regs()
    as same as the parameters of save_stack_trace_tsk().

    Cc: Ingo Molnar <mingo@elte.hu>
    Cc: yrl.pp-manager.tt@hitachi.com
    Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
    Cc: Frederic Weisbecker <fweisbec@gmail.com>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
    Cc: Namhyung Kim <namhyung@gmail.com>
    Cc: linux-kernel@vger.kernel.org
    Link: http://lkml.kernel.org/r/20110608070921.17777.31103.stgit@fedora15
    Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
    ---
    arch/x86/kernel/stacktrace.c | 2 +-
    arch/x86/mm/kmemcheck/error.c | 2 +-
    include/linux/stacktrace.h | 4 ++--
    3 files changed, 4 insertions(+), 4 deletions(-)

    diff --git a/arch/x86/kernel/stacktrace.c b/arch/x86/kernel/stacktrace.c
    index 55d9bc0..fdd0c64 100644
    --- a/arch/x86/kernel/stacktrace.c
    +++ b/arch/x86/kernel/stacktrace.c
    @@ -66,7 +66,7 @@ void save_stack_trace(struct stack_trace *trace)
    }
    EXPORT_SYMBOL_GPL(save_stack_trace);

    -void save_stack_trace_regs(struct stack_trace *trace, struct pt_regs *regs)
    +void save_stack_trace_regs(struct pt_regs *regs, struct stack_trace *trace)
    {
    dump_trace(current, regs, NULL, 0, &save_stack_ops, trace);
    if (trace->nr_entries < trace->max_entries)
    diff --git a/arch/x86/mm/kmemcheck/error.c b/arch/x86/mm/kmemcheck/error.c
    index 704a37c..dab4187 100644
    --- a/arch/x86/mm/kmemcheck/error.c
    +++ b/arch/x86/mm/kmemcheck/error.c
    @@ -185,7 +185,7 @@ void kmemcheck_error_save(enum kmemcheck_shadow state,
    e->trace.entries = e->trace_entries;
    e->trace.max_entries = ARRAY_SIZE(e->trace_entries);
    e->trace.skip = 0;
    - save_stack_trace_regs(&e->trace, regs);
    + save_stack_trace_regs(regs, &e->trace);

    /* Round address down to nearest 16 bytes */
    shadow_copy = kmemcheck_shadow_lookup(address
    diff --git a/include/linux/stacktrace.h b/include/linux/stacktrace.h
    index 25310f1..115b570 100644
    --- a/include/linux/stacktrace.h
    +++ b/include/linux/stacktrace.h
    @@ -14,8 +14,8 @@ struct stack_trace {
    };

    extern void save_stack_trace(struct stack_trace *trace);
    -extern void save_stack_trace_regs(struct stack_trace *trace,
    - struct pt_regs *regs);
    +extern void save_stack_trace_regs(struct pt_regs *regs,
    + struct stack_trace *trace);
    extern void save_stack_trace_tsk(struct task_struct *tsk,
    struct stack_trace *trace);

    --
    1.7.4.4



    \
     
     \ /
      Last update: 2011-06-09 19:33    [W:0.031 / U:63.036 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site